fix and add integration tests for installing from bitbucket/gitlab/github #755
Open
karawoo wants to merge 3 commits into
Open
fix and add integration tests for installing from bitbucket/gitlab/github #755karawoo wants to merge 3 commits into
karawoo wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #754
Fixes the existing bitbucket test which attempted to install falsy from a bitbucket repo that no longer exists. Replaces with the skeleton package that renv also tests against.
Adds a test for installing from github, and for all tests adds some additional logic to ensure that the package is actually installed and loadable.