Repository navigation
feat(srcts): Show keyboard shortcuts in a popup (#73) - #158
Merged
Merged
Conversation
Add a ? button to the header that lists every keyboard shortcut on hover or click, with key names for the user's OS. List the same shortcuts in the vignette.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73
Adds a
?button at the top right of the reactlog header, after the search bar. Hovering shows a table of every keyboard shortcut, and clicking keeps it open until clicked again. Key names follow the user's OS (Option/Cmd/Fn + ←for Home on Mac;Alt/Ctrl/Homeelsewhere). The navigation button tooltips use the same names; they used to show Mac symbols on every OS. The code is in the newsrcts/layout/shortcuts.ts.To verify: run
reactlog_show()(or openinst/reactlog/reactlog.html), hover the?, then click it and pressSpace. The step should advance while the table stays open. The vignette also gets a "Keyboard shortcuts" section with the same list.