Repository navigation
feat(R): Add reactlog_read() to read back reactlog_write() output - #159
Merged
Merged
Conversation
schloerke
force-pushed
the
schloerke/71-fix
branch
from
October 22, 2026 20:00
0e1afbf to
2935041
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reactlog_write()saves the log as JSON, but JSON does not keep the log'sversionattribute. Reading the file back with jsonlite gave a list thatreactlog_render()rejected with "missing a 'version' attribute", so a saved log could not be shown again.This adds
reactlog_read(file), which reads the JSON back as a list of entries and setsversion = "1"(the only log version so far).reactlog_show(reactlog_read("log.json"))now works.reactlog_write()docs link to it and show a save/read example.A new test writes a log, reads it back, checks the JSON is the same when written again, and renders it. Fixes #71.