Repository navigation
Conversation
…ule UIs Add tests for session filtering and file output in reactlog_write(), template filling and asset copying in reactlog_render(), time, session_token, and sizes in reactlog_widget(), the shiny option set by reactlog_enable()/reactlog_disable(), and module UI ids and the include_refresh flag.
schloerke
added this pull request to stack #163
October 22, 2026 20:26
schloerke
force-pushed
the
schloerke/160-more-unit-tests
branch
from
October 22, 2026 20:29
2c952e9 to
85bfe89
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for code that had none.
reactlog_write(): returns JSON whenfile = NULL, keeps global and matching-session entries whensession_tokenis set, and writes to a file.reactlog_render(): removes the template placeholders and thedefaultLog.jsscript, sets the time flag, and copiesreactlogAsset/next to the file.reactlog_enable()/reactlog_disable(): set theshiny.reactlogoption.reactlog_widget(): passestimeandsession_tokenthrough to the page, and setswidth,height, andelementId.reactlog_module_ui()/reactlog_widget_module_ui(): namespace their ids and drop the refresh button wheninclude_refresh = FALSE.Tests only, no package code changes. Stacked on #164.