Container Image creation and Github Action

[Xieyt]

GitHub Action & Workflow Integration:

• Added a new composite GitHub Action in action.yml to automate Frappe deployment and image building, supporting both pull and build-image commands with configurable inputs.
• Created a test workflow in .github/workflows/test.yml to run the build-image command using the new action and configuration file.
• Introduced a TOML configuration file .github/configs/test.toml to define site, app repositories, and Docker build settings for Frappe and Nginx.

BuildManager Enhancements:

Image Build Orchestration:

• Added methods to BuildManager for building Frappe base images, final images, and Nginx images, with support for multi-platform builds and Dockerfile rendering based on TOML config.

Repository Cloning:

• Refactored clone_apps to clone repositories in parallel using ThreadPoolExecutor, improving efficiency and reliability for multiple app clones.
• Added helper methods for parallel clone task execution and directory ownership management (chown_dir).

Bench Bake & Verification:

• Implemented an is_baked method to verify if a bench directory is ready for image building, checking assets and app installations.

Container Execution Improvements:

• Updated host_run to use the correct image and user based on new config structure, and improved logic for running commands inside containers, supporting both Frappe and Nginx images. [1] [2] [3]

These changes collectively provide a robust foundation for automated, configurable, and efficient Frappe deployments and image builds in CI/CD environments.

[1] [2] [3] [4] [5]

[Copilot]

Pull request overview

This pull request introduces comprehensive container image creation and GitHub Action workflow integration for automated Frappe deployment. The changes enable building Docker images for both Frappe and Nginx components with configurable TOML-based settings, and provide a reusable composite action for CI/CD pipelines.

Key Changes:

• Added a new build-image command to create Frappe and Nginx Docker images with multi-platform support
• Introduced GitHub Action composite action for automated deployment and image building workflows
• Refactored app cloning to use parallel execution with ThreadPoolExecutor for improved performance

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 25 comments.

Show a summary per file

File	Description
scripts/helpers.sh	New bash helper script providing logging, SSH setup, and remote execution utilities
scripts/deploy.sh	Main deployment script orchestrating pull and build-image commands
frappe_deployer/template/nginx.Dockerfile	Jinja2 template for building Nginx container images
frappe_deployer/template/frappe.Dockerfile	Jinja2 template for building Frappe container images with multi-stage build
frappe_deployer/config/config.py	Updated config model to support separate Frappe and Nginx build configurations with parallel app configuration
frappe_deployer/config/build.py	New build configuration models for Frappe and Nginx images with Dockerfile rendering
frappe_deployer/commands/build_image.py	New CLI command for building Docker images
frappe_deployer/commands/init.py	Updated to include new build_image command module
frappe_deployer/build_manager.py	Enhanced with image build orchestration, parallel cloning, and bench verification methods
frappe_deployer/deployment_manager.py	Refactored bench build process to run production builds twice for all apps
action.yml	GitHub composite action definition for deployment and image building
.github/workflows/test.yml	Test workflow demonstrating the action usage
.github/configs/test.toml	Example TOML configuration for testing image builds

Comments suppressed due to low confidence (3)

frappe_deployer/config/build.py:3

• Import of 'os' is not used.

import os

frappe_deployer/commands/build_image.py:6

• Import of 'os' is not used.

import os

frappe_deployer/commands/build_image.py:49

• Modification of the locals() dictionary will have no effect on the local variables.

    current_locals["build_nginx"] = {"name": "frappe-nginx", "push": push}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.