More specific checks and warnings for processing core

Author: monkstone

lib/jruby_art/core.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+# module encapsulates a check that the PROCESSING_ROOT exists
+module Core
+  def self.check?(path)
+    if File.directory?(path)
+      core_path = File.join(path, 'core/library/core.jar')
+      return true if File.exist?(core_path)
+      warn format('%s jar does not exist', core_path)
+    else warn format('%s directory does not exist', path)
+    end
+  end
+end
+
+# Provided processing distributions have the same nested structure ie:-
+# "core/library/core.jar" we can find "core.jar" when PROCESSING_ROOT exists

lib/jruby_art/installer.rb

@@ -31,8 +31,7 @@ def set_processing_root
   end
 
   def root_exist?
-    return false if config.empty?
-    File.exist? config['PROCESSING_ROOT']
+    Core.check?(config['PROCESSING_ROOT'])
   end
 
   def config
@@ -55,12 +54,13 @@ def show_version
 
 # Configuration checker
 class Check < Installer
+  require_relative 'core' 
   def install
     show_version
     return super unless config
     installed = File.exist? File.join(gem_root, 'lib/ruby/jruby-complete.jar')
-    proot = '  PROCESSING_ROOT = Not Set!!!' unless root_exist?
-    proot ||= "  PROCESSING_ROOT = #{config['PROCESSING_ROOT']}"
+    proot = '  PROCESSING_ROOT = Not Set Correctly!!!' unless root_exist?
+    proot ||= "  PROCESSING_ROOT = #{config['PROCESSING_ROOT']}"    
     sketchbook = "  sketchbook_path = #{config['sketchbook_path']}"
     template = "  template = #{config['template']}"
     java_args = "  java_args = #{config['java_args']}"