Remove bigdecimal dependency declaration#22
Open
mkllnk wants to merge 1 commit intoruby-rdf:developfrom
Open
Conversation
The BigDecimal class is not used in this code base. And since we have a circular dependency from rdf to rdf-turtle and back, we are otherwise unable to update the bigdecimal gem in the main rdf repository.
Author
|
@no-reply, are you in a position to review contributions? Is there anyone else in a better position? |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BigDecimal class is not used in this code base. And since we have a circular dependency from rdf to rdf-turtle and back, we are otherwise unable to update the bigdecimal gem in the main rdf repository.
So I'm violating the contrbuting guidelines here:
But I don't know which flow Gregg used to update those dependencies? Please let me know if there's a better approach.