Skip to content

Fix iogate.getc input byte order shuffled bug #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tompng wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

Fix iogate.getc input byte order shuffled bug #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/reline/io/ansi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,15 @@ def with_raw_input
end

def inner_getc(timeout_second)
unless @buf.empty?
return @buf.shift
end
until @input.wait_readable(0.01)
while true
# @buf may change while handling signal, so we need to check it in each loop iteration.
return @buf.shift unless @buf.empty?
break if @input.wait_readable(0.01)

timeout_second -= 0.01
return nil if timeout_second <= 0

# handle_signal may call cursor_pos which modifies @buf
Reline.core.line_editor.handle_signal
end
c = @input.getbyte
Expand Down