Conversation
|
I think the YAML indentation might need adjustment. It should follow a structure like: https://github.com/rubysec/ruby-advisory-db/blob/master/gems/activesupport/CVE-2009-3009.yml |
postmodern
left a comment
There was a problem hiding this comment.
@jamgregory this is the second time you have submitted advisories with incorrect indentation. Please be more careful and review the files before submitting a PR. See the CONTRIBUTING file for YAML style guidelines.
I'm not sure @jasnow - it didn't seem to be exported by the GHSA sync script, unless I missed it when bringing in the changes 🤔
Thanks for your feedback @wlads - I was using the GHSA sync script provided in the repository, so I'm not sure why the indentation wasn't correct.
Thanks for your feedback @postmodern - this was the output that was generated by the GHSA sync script in this repository. I had reviewed the files and run the tests (which passed locally) before I committed it, so I assumed the output was correct. Can any of you advise if you use any other linting tools before committing these to the repository? It seems like the sync script doesn't generate correct output so I'd like to ensure I'm following the same processes you all are. Should the tests be flagging up lines that are over 80 characters, for example? |
yamllint file |
I've just tried |
93d0d96 to
bd7322e
Compare
|
Sorry if this isn't the right place to ask, but should the |
Look at the other advisories in the repo - note that only the more recent release uses ">=" and the rest use "~>". |
I see, thanks. Since 8.0.5 should resolve the advisory the but is not included in the advisory solutions, would it be more appropriate to request that the scraper be run again for this PR? |
Please provide an example public repo with rails 8.0.5. Then I will run "bundle audit" to see if it is a problem. |
|
Is this the problem? If you run bundle audit check, you get: |
Yes, I believe |
@postmodern approves and merged into this repo : #1023 |
postmodern
left a comment
There was a problem hiding this comment.
~> X.Y.Z.W version constraints will exclude the X.Y.Z+1 version and above. Better to use ~> X.Y.Z, >= X.Y.Z.W.
I've added some new Rails vulnerabilities that GitHub security scanning has alerted me to.