Fix #1710: clarify DKIM hostname entries#1790
Open
Keegil wants to merge 1 commit intorunbox:masterfrom
Open
Conversation
Strip the domain suffix from DKIM hostnames in the provider-facing table so the values match the shorter hostname format most DNS control panels expect. runbox#1710
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement — Improves DKIM DNS setup instructions to reduce user error when entering records in domain provider interfaces.
Problem
The DKIM hostname table displayed full qualified names including the domain suffix (e.g.
selector._domainkey.domainyouown.com). Many DNS provider interfaces expect only the subdomain portion without the root domain, so users were inadvertently duplicating the domain when copy-pasting the entry. Issue #1710.Fix
Testing
npx tsc -p src/tsconfig.spec.json --noEmitpassesCloses #1710