Skip to content

add korean language#312

Open
mcfyynpy68-create wants to merge 3 commits into
runcat-dev:mainfrom
mcfyynpy68-create:main
Open

add korean language#312
mcfyynpy68-create wants to merge 3 commits into
runcat-dev:mainfrom
mcfyynpy68-create:main

Conversation

@mcfyynpy68-create
Copy link
Copy Markdown

add korean language

Context of Contribution

  • Bug Fix
  • Refactoring
  • New Feature
  • Others

Summary of the Proposal

Added Strings.ko.resx to the Properties folder to provide native Korean translation.

Reason for the new feature

Support korean language

Checklist

  • I have read the CONTRIBUTING.md and agree to follow it.
  • This PR does not contain commits of multiple contexts.
  • Code follows proper indentation and naming conventions.
  • Implemented using only APIs that can be submitted to the Microsoft Store.
  • Works correctly in both dark theme and light theme.
  • Works correctly on any device.

add korean language
Copy link
Copy Markdown
Collaborator

@mor39a mor39a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The necessary changes still need to be made to RunCat365/SupportedLanguage.cs and the README files

Comment thread RunCat365/Properties/Strings.ko.resx
Comment thread RunCat365/Properties/Strings.ko.resx
@mor39a mor39a added the localization Language translations, regional formats, units and locale-specific user experiences label Jun 1, 2026
mcfyynpy68-create and others added 2 commits June 2, 2026 02:13
Co-authored-by: Santiago Mora <89531894+mor39a@users.noreply.github.com>
Co-authored-by: Santiago Mora <89531894+mor39a@users.noreply.github.com>
@mor39a
Copy link
Copy Markdown
Collaborator

mor39a commented Jun 1, 2026

As stated in the CONTRIBUTING.md file:

  • Do not click Resolve conversation unless you are the reviewer.
    Even after pushing a fix in response to a review comment, only the reviewer can decide whether the issue is actually resolved.
    Pushing a follow-up commit and resolving the conversation yourself bypasses that judgment.

Edit: Sorry, I didn't realize that clicking Apply suggestion automatically marks the conversation as resolved. Please ignore the previous message.


Also, please make the necessary changes to RunCat365/SupportedLanguage.cs and the README files, so we can merge the changes

@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Jun 2, 2026

@mcfyynpy68-create
There have been similar challenge in the past. You might find it helpful as a reference for the translation.
#255

@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Jun 2, 2026

@mcfyynpy68-create @mor39a
There is a Claude Skill for localization. Even if you don't use it, it should serve as a helpful reference for the necessary tasks.
https://github.com/runcat-dev/RunCat365/blob/main/.claude/skills/add-localization/SKILL.md

@mor39a
Copy link
Copy Markdown
Collaborator

mor39a commented Jun 2, 2026

@mcfyynpy68-create @mor39a There is a Claude Skill for localization. Even if you don't use it, it should serve as a helpful reference for the necessary tasks. https://github.com/runcat-dev/RunCat365/blob/main/.claude/skills/add-localization/SKILL.md

I've never used it, but thanks for sharing it.
The skill should probably also include updating the README to keep the list of available languages up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localization Language translations, regional formats, units and locale-specific user experiences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants