Skip to content

Takeover of Death Shamer plugin#11412

Merged
pajlada merged 1 commit intorunelite:masterfrom
MylesAdams:deathshamer-takeover
Apr 14, 2026
Merged

Takeover of Death Shamer plugin#11412
pajlada merged 1 commit intorunelite:masterfrom
MylesAdams:deathshamer-takeover

Conversation

@MylesAdams
Copy link
Copy Markdown
Contributor

A week ago I submitted a PR (#11298) for a plugin that was a fork of an existing one.

You guys let me know about the plugin takeover policy, so I submitted an issue on the original plugin asking to become a contributor/takeover the plugin. I have not heard anything back, so I am submitting this PR to hopefully takeover the plugin. I have changed the repo to mine but the commit hash is the same.

Here is the issue I made: jack0lantern/raidshamer#5

@runelite-github-app
Copy link
Copy Markdown

Plugin repository has changed

raidshamer: 37fb5e20cdcc96db7f818e0e3cc389079409a9c6..37fb5e20cdcc96db7f818e0e3cc389079409a9c6

@runelite-github-app
Copy link
Copy Markdown

Feedback:

  • Use of java.lang.System.out is not allowed: system i/o, use a logger instead.

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@MylesAdams
Copy link
Copy Markdown
Contributor Author

Feedback:

  • Use of java.lang.System.out is not allowed: system i/o, use a logger instead.

A new scan will be automatically performed on the next push to the PR branch.

Internal use only: Reviewer details Maintainer details

I have already fixed this issue in new commits in my repo, but from what I understand this first takeover PR I am not supposed to change the hash. The last time this plugin was updated must have been before java.lang.System.out was disallowed.

@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Apr 7, 2026

Feedback:

  • Use of java.lang.System.out is not allowed: system i/o, use a logger instead.

A new scan will be automatically performed on the next push to the PR branch.
Internal use only: Reviewer details Maintainer details

I have already fixed this issue in new commits in my repo, but from what I understand this first takeover PR I am not supposed to change the hash. The last time this plugin was updated must have been before java.lang.System.out was disallowed.

You can ignore this feedback and fix it in a follow-up PR

@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Apr 7, 2026

@jack0lantern
Hi! @MylesAdams has been looking to collaborate with you on your plugin raidshamer. Since you haven't responded to the issue jack0lantern/raidshamer#5 - as per RuneLite's Plugin takeover policy - they are now looking to takeover your plugin. Please respond within two weeks if you have any objections to this.

We will attempt to contact you through this pull request again in one week.

@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Apr 14, 2026

@jack0lantern Hey, just giving you a heads up that in 1 week without your intervention, the plugin raidshamer will be transferred to @MylesAdams. Please let us know if you're against this.
Thanks!

@jack0lantern
Copy link
Copy Markdown
Contributor

Hey all, I haven't had time to play osrs as of late or test plugin changes. Go ahead and initiate the transfer!

@pajlada pajlada merged commit f8d03da into runelite:master Apr 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants