Merge upstream #2174: Add prioritized render scheduling - #49
Merged
Conversation
…intainer review Based on stakira's feedback: - Remove GetRenderInvalidations() command hook (over-complicated, never used) - Remove RenderInvalidation.cs and RenderInvalidationTest.cs - Revert all command changes (NoteCommands, ExpCommands, PartCommands) - Revert DocManager, PlaybackManager, RenderEngine, Notifications changes Keep the existing RenderPriority and phrase ordering logic intact: - RenderPriority.cs (sorting rules) - OrderForPlayback / OrderForPreRender in RenderEngine - PreRenderNotification with focusPart/focusTick Update RenderPriorityTest: - Remove Overlaps tests (method doesn't exist in master) - Rename methods for consistency - Add PlaybackDistance coverage
Cherry-picked from openutau#2174: openutau#2174 Resolved real conflicts against features already on our master: - RenderEngine.cs constructor: combined the XSY cross-synthesis blend cache (openutau#2261) with this PR's focusPart/focusTick priority params. - RenderEngine.cs render loop: kept this PR's cancellation-check-before-unpack ordering, combined with openutau#2261's XSY blending branch (both operate on the same tuple, not mutually exclusive). - PlaybackManager.cs: kept both state resets on LoadProjectNotification (live waveform cache clear from openutau#2119, focus-part/tick reset from this PR) since neither depends on the other.
runit-xze
added a commit
that referenced
this pull request
Jul 25, 2026
Merge upstream openutau#2174: Add prioritized render scheduling
runit-xze
added a commit
that referenced
this pull request
Jul 25, 2026
Merge upstream openutau#2174: Add prioritized render scheduling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in stakira/OpenUtau#2174.
Previously closed as #34. Real conflicts against openutau#2261 (XSY cross-synthesis) and openutau#2119 (Render Live Waveforms), both already on our master. Resolved by combining: RenderEngine's constructor now has both the XsyBlendCache field and the focusPart/focusTick priority params; the render loop keeps this PR's cancellation-check-first ordering while preserving the XSY blending branch; PlaybackManager resets both the live waveform cache and the focus-part/tick state on project load.