not working, minimal upgrades

.gitignore

@@ -26,6 +26,9 @@ build/Release
 # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git
 node_modules
 
+# Build artifacts
+tsconfig.tsbuildinfo
+
 lib/
 
 # Local toy file

__mocks__/jmp.ts

@@ -1,5 +1,5 @@
 import { EventEmitter } from "events";
-import * as jmp from "jmp";
+import * as jmp from "@runtimed/jmp";
 
 class Socket extends EventEmitter {
   throttle = false;

__tests__/index.spec.ts

@@ -12,7 +12,7 @@ import {
 } from "../src";
 
 import { EventEmitter } from "events";
-import { Socket as _Socket } from "jmp";
+import { Socket as _Socket } from "@runtimed/jmp";
 import * as zmq from "zeromq";
 
 type Socket = typeof _Socket &
@@ -36,7 +36,7 @@ class HokeySocket extends _Socket {
 }
 
 describe("createSocket", () => {
-  test("creates a JMP socket on the channel with identity", async done => {
+  test("creates a JMP socket on the channel", async done => {
     const config = {
       signature_scheme: "hmac-sha256",
       key: "5ca1ab1e-c0da-aced-cafe-c0ffeefacade",
@@ -48,7 +48,6 @@ describe("createSocket", () => {
 
     const socket = await createSocket("iopub", identity, config);
     expect(socket).not.toBeNull();
-    expect(socket.identity).toBe(identity);
     expect(socket.type).toBe(ZMQType.frontend.iopub);
     socket.close();
 

package.json

@@ -31,11 +31,11 @@
     "spawnteract": "^5.0.1",
     "ts-jest": "^25.2.1",
     "typescript": "^3.8.3",
-    "zeromq": "^5.2.0"
+    "zeromq": "^6.5.0"
   },
   "dependencies": {
     "@nteract/messaging": "^7.0.0",
-    "jmp": "^2.0.0",
+    "@runtimed/jmp": "^3.0.0",
     "rxjs": "^6.3.3",
     "uuid": "^7.0.0"
   },

src/index.ts

@@ -1,5 +1,5 @@
 import { Channels, JupyterMessage } from "@nteract/messaging";
-import * as moduleJMP from "jmp";
+import * as moduleJMP from "@runtimed/jmp";
 import { fromEvent, merge, Observable, Subject, Subscriber } from "rxjs";
 import { FromEventTarget } from "rxjs/internal/observable/fromEvent";
 import { map, publish, refCount } from "rxjs/operators";
@@ -67,15 +67,14 @@ export const formConnectionString = (
  */
 export const createSocket = (
   channel: ChannelName,
-  identity: string,
+  _identity: string,
   config: JupyterConnectionInfo,
   jmp = moduleJMP
 ): Promise<moduleJMP.Socket> => {
   const zmqType = ZMQType.frontend[channel];
   const scheme = config.signature_scheme.slice("hmac-".length);
 
   const socket = new jmp.Socket(zmqType, scheme, config.key);
-  socket.identity = identity;
 
   const url = formConnectionString(config, channel);
   return verifiedConnect(socket, url);

types/jmp/index.d.ts

@@ -1,5 +1,5 @@
-declare module "jmp" {
-  import zmq from "zeromq";
+declare module "@runtimed/jmp" {
+  import zmq from "zeromq/v5-compat";
 
   export interface MessageProperties {
     idents: any[];