Implement P2PKH support and legacy signing method#66
Open
aagbotemi wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add BIP-137 legacy message signing/verification and BIP-322 P2PKH support.
Rebased on #65.
Changes
sign_legacy_encodedandverify_legacy_encodedfor the BIP-137 legacy formatcreate_message_signature_p2pkh/verify_full_p2pkhfor BIP-322 P2PKH signing and verificationInvalidRecoveryFlagandLegacyRecovererror variantsNote
Legacy is restricted to P2PKH, both sign and verify reject non-P2PKH addresses.
Closes #35
Closes #36