[beta 1.96] Revert "feat: add frame-pointers profile option (#16742)"#16998
Merged
weihanglo merged 2 commits intoMay 15, 2026
Conversation
rustbot
added
A-build-execution
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
weihanglo
approved these changes
May 15, 2026
Contributor
|
This revert is directly against beta. Are we also going to revert in |
See https://github.com/rust-lang/cargo/actions/runs/24515552632/job/71658352382?pr=16892 ``` error: test failed for example starting on line 1322: expected error message not found in compiler output Expected: the trait `Trait` is not dyn compatible Got: error[E0038]: the trait `updated_crate::Trait` is not dyn compatible --> /tmp/.tmp0LpIwx/example.rs:10:22 | 10 | let obj: Box<dyn Trait> = Box::new(Foo); | ^^^^^ `updated_crate::Trait` is not dyn compatible | note: for a trait to be dyn compatible it needs to allow building a vtable for more information, visit <https://doc.rust-lang.org/reference/items/traits.html#dyn-compatibility> --> /tmp/.tmp0LpIwx/after.rs:6:11 | 6 | const CONST: i32 = 123; | ^^^^^ the trait is not dyn compatible because it contains associated const `CONST` = help: only type `Foo` implements `updated_crate::Trait`; consider using it directly instead. error: aborting due to 1 previous error ```
ehuss
changed the title
Contributor
Author
|
Sure, posted #16999 for master, too. |
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 16, 2026
[beta-1.96] Update cargo submodule 1 commits in 9fb171546a9db5513062de20df78116ed5ee7668..bfa14ef47afbddd88d6be1913a0e486386a566a2 2026-04-14 20:13:35 -0500 to 2026-05-15 13:10:54 -0400 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16998) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 16, 2026
[beta-1.96] Update cargo submodule 1 commits in 9fb171546a9db5513062de20df78116ed5ee7668..bfa14ef47afbddd88d6be1913a0e486386a566a2 2026-04-14 20:13:35 -0500 to 2026-05-15 13:10:54 -0400 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16998) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 17, 2026
[beta-1.96] Update cargo submodule 1 commits in 9fb171546a9db5513062de20df78116ed5ee7668..bfa14ef47afbddd88d6be1913a0e486386a566a2 2026-04-14 20:13:35 -0500 to 2026-05-15 13:10:54 -0400 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16998) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3c95ccc, reversing changes made to da53118.
A concern was raised about the force-off option which may be confusing because it doesn't force them "off", it turns off the "force on" option. Force-off is the default and can change per target.
Backport to get CI to pass: