Fix JS error when menu is closed and alt key is pressed#2846
Merged
Conversation
syphar
requested changes
Jun 19, 2025
Member
syphar
left a comment
There was a problem hiding this comment.
I can still reproduce the error with these changes, or is it just another place?
( I tried with the "About" menu )
Member
|
Also, the real question is: |
Member
Author
Hum, weird. Gonna test some more then.
A human needs to have their secret. 😛 (I literally just saw an error after switching windows when working on #2847) |
5ca70a4 to
4253c62
Compare
Member
Author
|
Ah indeed. So |
syphar
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's how I trigger the bug:
altkey.Now the fun part: it doesn't happen all the time so can't really write a GUI test for it. ^^'