Skip to content

Replace x86_64-apple-darwin with aarch64-apple-darwin as default target#2927

Merged
syphar merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:replace-default-apple-target
Oct 15, 2025
Merged

Replace x86_64-apple-darwin with aarch64-apple-darwin as default target#2927
syphar merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:replace-default-apple-target

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez commented Oct 1, 2025

Fixes #2926.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner October 1, 2025 15:18
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 1, 2025
@GuillaumeGomez
Copy link
Copy Markdown
Member Author

GuillaumeGomez commented Oct 1, 2025

The failing tests are marked as "ignore"?

@syphar
Copy link
Copy Markdown
Member

syphar commented Oct 1, 2025

The failing tests are marked as "ignore"?

Ignore are the build tests. We didn't want to run them locally but only in ci.

So it's tests that need fixing.

That being said, I remember build tests on master are failing too, if they are the same on this PR it's unrelated to this change

syphar
syphar requested changes Oct 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the failing build-tests (ignored tests), one is also failing on master (test_no_implicit_features_for_optional_dependencies_with_dep_syntax), but another one is related to this PR and has to be fixed (test_build_crate).

One thing I'm not sure about:
wouldn't this be something like a breaking change where we need to inform crate authors?

@GuillaumeGomez
Copy link
Copy Markdown
Member Author

GuillaumeGomez commented Oct 2, 2025

wouldn't this be something like a breaking change where we need to inform crate authors?

I guess it wouldn't hurt to do so. How are we supposed to announce it though? Rust blog post?

@GuillaumeGomez GuillaumeGomez force-pushed the replace-default-apple-target branch from 4458957 to 2d65f42 Compare October 2, 2025 09:45
@GuillaumeGomez
Copy link
Copy Markdown
Member Author

GuillaumeGomez commented Oct 2, 2025

Fixed the test (the other one still fails).

@syphar syphar mentioned this pull request Oct 15, 2025
Merged
@syphar syphar merged commit dd8870c into rust-lang:master Oct 15, 2025
8 of 9 checks passed
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 15, 2025
@GuillaumeGomez GuillaumeGomez deleted the replace-default-apple-target branch October 15, 2025 18:37
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 15, 2025
@syphar syphar mentioned this pull request Oct 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syphar syphar syphar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make aarch64-apple-darwin a default target

2 participants

@GuillaumeGomez @syphar