fix parsing dependencies from release list#2984
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
force-pushed
the
fix-parse-dependences
branch
2 times, most recently
from
8e917d1 to
5cd2eca
Compare
syphar
force-pushed
the
fix-parse-dependences
branch
from
5cd2eca to
7aacaec
Compare
Member
Author
|
I pushed two ideas, let's chat :) I can also imagine naming the variants as versions ( |
GuillaumeGomez
approved these changes
Nov 7, 2025
Member
|
Looks good to me, thanks! |
github-actions
Bot
added
the
S-waiting-on-deploy
github-actions
Bot
removed
the
S-waiting-on-review
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on another refactor I realized that the serde parsing I used for the release dependencies didn't really cover the old-style tuples in the database as I thought it would.
This wouldn't have caused server errors, but we would have had empty dependency lists.
Now I have a code representation of all things we can have in the database. I validated that with an export of the actual production database. So there is no confusion :)