add build-time ETag to /-/static/* responses & return "304 Not Modified"#3017
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
force-pushed
the
etag-static-2
branch
from
c4bbe3e to
e60c5cd
Compare
syphar
force-pushed
the
etag-static-2
branch
from
e60c5cd to
620d89c
Compare
GuillaumeGomez
approved these changes
Nov 22, 2025
Member
|
We keep adding more deps. T_T Build time (from clean) on my computer is getting in high numbers. |
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first step of #1560, extracted from #3006.
Can save quite a bit of transfer time for slow connections, but also saves time between CDN & origin. Of course, not specifically for these files, it's just the ones I started with.
Generally I want to try not to use the often "simple" etag impl that would aways generate the full html, then MD5-Hash it, and only then comparing it with
If-None-Match. Better is to work with an ETag that can be generated without fetching the actual content.Next steps after this:
ETag/If-None-Matchto rustdoc asset handlers (toolchain & invocation)