add etag & conditional get to rustdoc html output#3035
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
force-pushed
the
etag-rustdoc
branch
7 times, most recently
from
c0dfd4c to
dc39caf
Compare
syphar
changed the title
Member
Author
|
@GuillaumeGomez this one can be reviewed now, will safe some time between browsers & cdn, but mainly between CDN & origin. |
GuillaumeGomez
force-pushed
the
etag-rustdoc
branch
from
cbb2a26 to
d5992f1
Compare
…is never forgotten
Member
Author
|
additional commits LGTM |
GuillaumeGomez
approved these changes
Nov 27, 2025
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most interesting piece for #1560 .
Using a safe approach for etag generation, without having to download or rewrite the HTML from storage.
I wasn't 100% certain about adding the dependency, let me know what you think :)
( alternative is to add
serde::Serializeeverywhere and usingserde_jsonto serizlialize into the hash)