fix build performance tracing#3155
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Jan 21, 2026
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to look into performance traces for builds, and discovered they are all over the place.
Mainly: the main
docbuilder.build_packagetrace is not connected to the child traces.I'm not 100% sure if these changes solve it completely, but I definitely discovered these issues, and they are fixed by the PR:
ctx.operation()andctx.name()and fixed the filter.spawn_blockingfunction that takes care of passing on the parent span into the task because tokio doesn't. I realized thatblock_onhas the same issue. For now I just used the new fixed handle for builds. If it solves the issues there, I'll move thespawn_blockingfn into the handler too, and update the whole codebase.