Skip to content

move builder build_package performance transaction parent, add spans #3162

Merged
syphar merged 3 commits into
rust-lang:mainfrom
syphar:fix-tracing-build
Jan 25, 2026
Merged

move builder build_package performance transaction parent, add spans #3162
syphar merged 3 commits into
rust-lang:mainfrom
syphar:fix-tracing-build

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented Jan 23, 2026

So, I really hope that this fixes the issue.

Generally:

  • I moved the transaction parent up one level, so everything we do for one build is in that transaction. Missing previously: toolchain updates, builder docker image download / update
  • I used the new block_on with tracing in the build queue
  • After having slept I now feel like Deref is wrong for this use-case, there are cases where people would accidentally call the wrong method.
  • I fixed the default log-directive (though this directive is overwritten anyways on the server).

This time I locally ran the old build-server (via daemon), and new (via builder-binary), and in both cases I only saw the parent-transaction I want, and never the parent-less child spans we see in prod.

@syphar syphar self-assigned this Jan 23, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 23, 2026
@syphar syphar force-pushed the fix-tracing-build branch 4 times, most recently from 80950c2 to f1c60eb Compare January 25, 2026 08:13
@syphar syphar force-pushed the fix-tracing-build branch from f1c60eb to 53911ab Compare January 25, 2026 08:18
@syphar syphar changed the title WIP: experiments to fix build tracing move builder build_package performance transaction parent, add spans Jan 25, 2026
@syphar syphar marked this pull request as ready for review January 25, 2026 08:20
@syphar syphar requested a review from a team as a code owner January 25, 2026 08:20
@syphar
Copy link
Copy Markdown
Member Author

syphar commented Jan 25, 2026

@GuillaumeGomez this can be reviewed now

@syphar syphar merged commit f194f2b into rust-lang:main Jan 25, 2026
14 checks passed
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 25, 2026
@syphar syphar deleted the fix-tracing-build branch January 25, 2026 16:05
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants