Skip to content

Handle JSON generation like other errors instead of bailing out #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GuillaumeGomez wants to merge 1 commit into from
Closed

Handle JSON generation like other errors instead of bailing out #3218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,7 @@ impl RustwideBuilder {
}
};

if let Err(err) = self.execute_json_build(
self.execute_json_build(
build_id,
name,
version,
Expand All @@ -1146,16 +1146,7 @@ impl RustwideBuilder {
build,
metadata,
limits,
) {
// FIXME: this is temporary. Theoretically all `Err` things coming out
// of the method should be retryable, so we could juse use `?` here.
// But since this is new, I want to be carful and first see what kind of
// errors we are seeing here.
error!(
?err,
"internal error when trying to generate rustdoc JSON output"
);
}
)?;

let result = {
let _span = info_span!("cargo_build", target = %target, is_default_target).entered();
Expand Down
Loading