introduce global anomalies, build queue length, + manual via CLI by syphar · Pull Request #3274 · rust-lang/docs.rs

syphar · 2026-04-02T19:40:44Z

( updated description).

introduce "abnormality" to warn users about currently active issues.

Sources are (first version):

automatic for a too long queue
manual abnormaly in the database for the rest.

This is not for notifications, but only this kind of system status information. The topbar icon is a partial that is cached in the CDN. Notifications / alerts will be cached in the same way (partial + cdn) but shown via popup & discardable.

We cache the value for 10 minutes, so we won't have too many added database queries.

Topbar partial:

We also have the added detail status page with more explanation.

the queue warning is additionally shown on the queue page

The audit error is fixed in #3295

GuillaumeGomez · 2026-04-02T21:55:18Z

I think you're trying to fix two different problems here:

docs.rs issues
docs.rs changes

The first one needs to be there as long as the issue(s) are there. The second one being a notice, it should be discard-able by the user and attract attention a lot more. So your PR fits well for 1., but doesn't for 2. imo. 2. should most likely be a static element floating over the content.

What do you think?

syphar · 2026-04-04T11:23:26Z

I admit I didn't think much further than just making the old feature not hardcoded, so we can start showing something somewhere.

I don't think I can build either of the other approaches in the next week, but hopefully some time after that, depending on many other factors.

syphar · 2026-04-04T11:25:25Z

I think you're trying to fix two different problems here:
1. docs.rs issues

2. docs.rs changes
The first one needs to be there as long as the issue(s) are there. The second one being a notice, it should be discard-able by the user and attract attention a lot more. So your PR fits well for 1., but doesn't for 2. imo. 2. should most likely be a static element floating over the content.

What do you think?

Right now I don't have an opinion on that (too tired / sick), how does crates.io do it?

Generally what you propose feels like it makes sense.

syphar · 2026-04-04T11:27:28Z

general thought:

with my dayjob problems right now, I don't think I can spend time on any of the proposed other things in the next week or two (except when I'm lucky, not sure).

so I'm asking myself if we should use this first to make people aware of the new default-target change first?

GuillaumeGomez · 2026-04-04T13:16:54Z

I can take over this PR and implement the missing parts if you want?

syphar · 2026-04-07T05:38:58Z

I can take over this PR and implement the missing parts if you want?

thanks for the offer!

My hunch is that you're right generally, but I want to think it through first when I'm a little better.

syphar · 2026-04-07T05:39:19Z

( will set the compiled-in warning in a separate PR for the current change only)

GuillaumeGomez · 2026-04-07T09:10:17Z

Sounds good to me. :)

syphar · 2026-04-07T21:53:46Z

@GuillaumeGomez I had another idea about multiple alerts, the separate page looked so empty with the information that was there..

what do you think?

It would collapse (so no dropdown) when there is only one alert.

Also now there is an example how the webserver now collects metrics from the builder-lib.

( not sure if I was too much into it and overengineered 😅 )

GuillaumeGomez · 2026-04-07T21:55:39Z

Well, I was kinda hoping to provide more information for each anomaly on the page. 😆

Like since how long it's happening, what's the impact to users, etc.

syphar · 2026-04-08T09:39:35Z

Well, I was kinda hoping to provide more information for each anomaly on the page. 😆

Like since how long it's happening, what's the impact to users, etc.

Want to add a commit how you would imagine it?

GuillaumeGomez · 2026-04-08T09:42:35Z

I can try. :)

syphar · 2026-04-08T09:44:48Z

I just rebased to fix the conflicts, will leave it alone now @GuillaumeGomez

GuillaumeGomez · 2026-04-08T12:53:49Z

I added the draft for the status page of docs.rs. It looks like this:

syphar · 2026-04-15T20:33:52Z

valid points, good idea, we can do that.

I assume that we merge the Abnormality and GlobalAlert things?

the abnormality only has the explanation & start-time on top?

GuillaumeGomez · 2026-04-15T20:35:43Z

GlobalAlert is different: it's like the one you can see on crates.io currently. It's supposed to have a start and an end date so we know when to render it to users.

syphar · 2026-04-15T21:36:25Z

will finish up this PR and ping you for the final review.

syphar · 2026-04-24T09:12:32Z

Then instead of a link only appearing in case there are anomalies. Should we have a "docs.rs status" link? Like that it never changes and we're all good.

I think I would want alerts ( and anomalies) always visible, and not behind a click.

I'll (try to) update this PR, so the anomalies are loaded in a separate small partial, and then injected into the topbar, similar to how we load the version-list in the main dropdown.

syphar · 2026-04-24T09:14:00Z

this change might also make this PR much less complex, since I don't have to inject the anomalies into all pages any more

GuillaumeGomez · 2026-04-24T13:07:33Z

Then instead of a link only appearing in case there are anomalies. Should we have a "docs.rs status" link? Like that it never changes and we're all good.

I think I would want alerts ( and anomalies) always visible, and not behind a click.

I'll (try to) update this PR, so the anomalies are loaded in a separate small partial, and then injected into the topbar, similar to how we load the version-list in the main dropdown.

Hmmmmm. The whole caching thing is really getting in the way here. ^^'

syphar · 2026-04-26T17:41:11Z

Then instead of a link only appearing in case there are anomalies. Should we have a "docs.rs status" link? Like that it never changes and we're all good.

I think I would want alerts ( and anomalies) always visible, and not behind a click.
I'll (try to) update this PR, so the anomalies are loaded in a separate small partial, and then injected into the topbar, similar to how we load the version-list in the main dropdown.

Hmmmmm. The whole caching thing is really getting in the way here. ^^'

perhaps. But like this, with just some well designed pages, we can have super fast server-side generated pages :)

syphar · 2026-04-26T20:08:02Z

-                {# The global alert, if there is one #}
-                {% include "header/global_alert.html" -%}
+                {# The current abnormalities, if there are any #}
+                <div id="abnormalities" tabindex="-1" data-url="/-/partial/abnormalities/"></div>


@GuillaumeGomez

this is how I would imagine this,

not knowing what the best way is to have this placeholder here.

View changes since the review

Just put a <a href="/-status">status</a> and that's the element where we'll add the ⚠️ if there is something wrong currently.

syphar · 2026-04-26T20:08:49Z

        }
    });
+
+    (async function loadAbnormalities() {


@GuillaumeGomez

this is just AI generated code, to show you what I meant with the partial.

I assume we should do it differently? not sure what's the best way.

View changes since the review

I would always link to the docs.rs status page and only query a /-/is_there_anomalies/ URL on docs.rs and add a ⚠️ in such case. That would be the only thing changed, the URL remains the same etc.

I updated the partial to show less.

( I still don't know if that JS is ok or not, i would need help for that :) )

I still don't understand what you're trying to do here. It seems like you're loading a whole HTML file and not just add a ⚠️ in the topbar link text.

syphar · 2026-04-26T20:11:23Z

@GuillaumeGomez I updated the implementation to what I think we should do.

The template & JS change just as a proof of concept, need your help to finish this up.

I assume the alerts could also use a similar concept?

GuillaumeGomez · 2026-04-26T22:01:46Z

Not sure to agree with your approach. Why do you want them to be available in the topbar directly? It's one click in any case, whether we list abnormalities in the topbar or if we have a link to the docs.rs status page. I can add a JS part to add a ⚠️ symbol if there is a current abnormality but I don't think it's a good idea to list them directly in the topbar.

syphar · 2026-05-12T20:43:11Z

Not sure to agree with your approach. Why do you want them to be available in the topbar directly? It's one click in any case, whether we list abnormalities in the topbar or if we have a link to the docs.rs status page. I can add a JS part to add a ⚠️ symbol if there is a current abnormality but I don't think it's a good idea to list them directly in the topbar.

I just realized this is waiting for my answer 😅

I think I want something in the topbar that shows that something is wrong.

This is still the html partial, just returning the icon I presume.

GuillaumeGomez · 2026-05-12T21:55:46Z

Also: no more global alert/message?

syphar · 2026-05-12T21:58:53Z

@GuillaumeGomez
I

simplified the topbar partial
dropped the WarningsCache. The CDN can cache the partial, that's enough.
dropped the alert-severity for simplification

What do you think?

syphar self-assigned this Apr 2, 2026

syphar requested a review from a team as a code owner April 2, 2026 19:40

github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 2, 2026

syphar force-pushed the custom-warning branch from 1758a96 to 873ce8e Compare April 2, 2026 19:48

syphar force-pushed the custom-warning branch from 34be377 to 35daa3f Compare April 7, 2026 21:16

This comment has been minimized.

Sign in to view

syphar force-pushed the custom-warning branch 2 times, most recently from e2b4f07 to 0bc9736 Compare April 7, 2026 21:51

This comment has been minimized.

Sign in to view

syphar force-pushed the custom-warning branch from 0bc9736 to e2dbbf2 Compare April 8, 2026 09:44

This comment has been minimized.

Sign in to view

syphar marked this pull request as draft April 15, 2026 21:36

This comment has been minimized.

Sign in to view

syphar force-pushed the custom-warning branch 5 times, most recently from 23bb168 to a99154e Compare April 26, 2026 19:46

syphar commented Apr 26, 2026

View reviewed changes

syphar force-pushed the custom-warning branch from 1cacd85 to 2b0c85c Compare April 26, 2026 20:09

syphar and others added 6 commits May 12, 2026 22:43

allow setting global alert from the database / CLI

1ee9fd3

extend global-alert with queue length alert & prep for more

0d0b791

Add status reporting page

ec70950

rename to abnormalities, finish up the rest

c060ef0

rename handlers::status to handlers::build_status

b11672d

change abnormality loading to JS / partial

276de11

syphar force-pushed the custom-warning branch from 2b0c85c to 276de11 Compare May 12, 2026 20:43

drop warnings-cache, only cache partial in CDN, drop start_time

deb7458

syphar force-pushed the custom-warning branch from 6d8ee99 to deb7458 Compare May 12, 2026 21:31

drop abnormality severity

13611a9

syphar force-pushed the custom-warning branch from bcee266 to 13611a9 Compare May 12, 2026 21:48

syphar requested a review from GuillaumeGomez May 12, 2026 21:57

syphar marked this pull request as ready for review May 12, 2026 21:59

Conversation

syphar commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Apr 2, 2026

Uh oh!

syphar commented Apr 4, 2026

Uh oh!

syphar commented Apr 4, 2026

Uh oh!

syphar commented Apr 4, 2026

Uh oh!

GuillaumeGomez commented Apr 4, 2026

Uh oh!

syphar commented Apr 7, 2026

Uh oh!

syphar commented Apr 7, 2026

Uh oh!

GuillaumeGomez commented Apr 7, 2026

Uh oh!

This comment has been minimized.

syphar commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

syphar commented Apr 8, 2026

Uh oh!

GuillaumeGomez commented Apr 8, 2026

Uh oh!

This comment has been minimized.

syphar commented Apr 8, 2026

Uh oh!

GuillaumeGomez commented Apr 8, 2026

Uh oh!

syphar commented Apr 15, 2026

Uh oh!

GuillaumeGomez commented Apr 15, 2026

Uh oh!

syphar commented Apr 15, 2026

Uh oh!

This comment has been minimized.

syphar commented Apr 24, 2026

Uh oh!

syphar commented Apr 24, 2026

Uh oh!

GuillaumeGomez commented Apr 24, 2026

Uh oh!

syphar commented Apr 26, 2026

Uh oh!

syphar Apr 26, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez May 12, 2026

Choose a reason for hiding this comment

Uh oh!

syphar Apr 26, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez May 12, 2026

Choose a reason for hiding this comment

Uh oh!

syphar May 12, 2026

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez May 12, 2026

Choose a reason for hiding this comment

Uh oh!

syphar commented Apr 26, 2026

Uh oh!

GuillaumeGomez commented Apr 26, 2026

Uh oh!

syphar commented May 12, 2026

Uh oh!

GuillaumeGomez commented May 12, 2026

Uh oh!

syphar commented Apr 2, 2026 •

edited

Loading

syphar commented Apr 7, 2026 •

edited

Loading

GuillaumeGomez commented Apr 7, 2026 •

edited

Loading

syphar Apr 26, 2026 •

edited by rustbot

Loading

syphar Apr 26, 2026 •

edited by rustbot

Loading