-
Notifications
You must be signed in to change notification settings - Fork 41
document Closure capture precision #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tshepang
wants to merge
26
commits into
main
Choose a base branch
from
tshepang/capture-precision
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1fcde97
document Closure capture precision
tshepang ab0c74d
typo
tshepang c128b74
use a defined term
tshepang f072119
remove a redundancy, and add some links
tshepang 88e7bbf
grammar and consistency fix
tshepang a983ac1
link-it
tshepang eefb10d
define the term before using it
tshepang f502ea2
be more consise and clear, remove redundancy, and link to a definition
tshepang 90678f7
be more consise and clear, remove redundancy, and link to some defini…
tshepang 2d0f3fa
clarity
tshepang d109649
missing word
tshepang d611518
dangling term
tshepang 74ce3c8
move to a more suitable place
tshepang 5c2ae24
be less verbose (and nearly all the paragraphs are rules, so don't ov…
tshepang 5b89a38
link-it
tshepang 3de56f1
match FLS style, and re-oder one rule
tshepang 6bbae9b
fix links
tshepang fb39a56
these should not be conflated
tshepang 550f10d
add some clarity
tshepang e66de62
add pattern destructing rules
tshepang a0f78bc
clarity
tshepang 3279af3
sort
tshepang 8053946
more sorting
tshepang 3056e1f
create section for pattern destructuring
tshepang 03503ca
link-it
tshepang 7713de9
fix
tshepang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paragraph-ID list itself looks fine, but this changelog attribution still seems too broad.
The changed capture-mode paragraphs fit rust-lang/rust#150681, but the new capture-precision block spans multiple sources: some items align with the later pattern/discriminant work in rust-lang/rust#138961 and rust-lang/reference#1837, while others are pre-existing Reference behavior now being documented here.
Could this entry be split, or reworded so
#150681is not presented as introducing the whole block? The note that these paragraphsmostly document behavior that existed before this releasealready points in that direction.Support:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can go find where each behavior was added, but am not sure it's worth the time
maybe a good compromise is having a different heading, like "Pre-existing behavior before 1.95", or just "FLS maintenance"