Network entry API#5049
Open
Rawk wants to merge 3 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
stable-nominated
Rawk
force-pushed
the
unix-network-entry
branch
from
89888d3 to
a7783fd
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
JohnTitor
requested changes
May 17, 2026
Comment on lines
+210
to
+213
| n_name: *mut c_char, | ||
| n_aliases: *mut *mut c_char, | ||
| n_addrtype: c_int, | ||
| n_net: u32, |
Member
There was a problem hiding this comment.
You should also add getnetbyname and getnetbyaddr
| pub fn getnetbyname(name: *const c_char) -> *mut netent; | ||
| pub fn getnetbyaddr(net: u32, type_: c_int) -> *mut netent; | ||
| pub fn setnetent(stayopen: c_int); | ||
| pub fn endnetent(); |
Member
There was a problem hiding this comment.
I wonder if this had the same situation as setservent/endservent and we might need a test tweak.
cc @jclulow, @pfmooney for confirmation
Line 1173 in a3e451c
https://github.com/illumos/illumos-gate/blob/5425aa59e8fd3834b86390ed6d8a13586c918df9/usr/src/head/netdb.h#L288-L305
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add functions and struct for the "get network entry" API, including the reentrant GNU extension.
Sources
glic/resolv/netdb.h
Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated