fix: not complete same name inherent deref methods

[A4-Tacks]

Fixes #20773

Motivation: #20773 (comment)

I'm not sure if Object and WhereClause were handled correctly

Example

fn test(a: A) {
    a.$0
}
impl core::ops::Deref for A {
    type Target = B;
    fn deref(&self) -> &Self::Target { loop {} }
}
trait Foo { fn foo(&self) -> u32 {} }
impl Foo for A {}
impl Foo for B {}
impl A { fn foo(&self) -> u8 {} }
impl B { fn foo(&self) -> u16 {} }
struct A {}
struct B {}

Before this PR

me foo()             fn(&self) -> u8
me foo()            fn(&self) -> u16
me foo() (as Foo)   fn(&self) -> u32

After this PR

me foo()             fn(&self) -> u8
me foo() (as Foo)   fn(&self) -> u32

[ChayimFriedman2]

One request. Also it'll be nice to add a test for the invisible method case.

View changes since this review

[ChayimFriedman2]

Should move that inside the if, otherwise invisible methods can override visible methods.

[A4-Tacks]

Thank you for catch this, but fixing it is not that simple, I am currently working on it

[ChayimFriedman2]

Why inserting it under the if can't solve this?

[A4-Tacks]

Because on_inherent_method is not called ordered

I think we need to block until we fix the order based on another PR

For the following code, I printed the log and output FEACDB:

pub struct A {}
pub struct B {}
pub struct C {}
pub struct D {}
pub struct E {}
pub struct F {}
impl core::ops::Deref for A {
    type Target = B;
    fn deref(&self) -> &Self::Target { loop {} }
}
impl core::ops::Deref for B {
    type Target = C;
    fn deref(&self) -> &Self::Target { loop {} }
}
impl core::ops::Deref for C {
    type Target = D;
    fn deref(&self) -> &Self::Target { loop {} }
}
impl core::ops::Deref for D {
    type Target = E;
    fn deref(&self) -> &Self::Target { loop {} }
}
impl core::ops::Deref for E {
    type Target = F;
    fn deref(&self) -> &Self::Target { loop {} }
}

[ChayimFriedman2]

Hmm, weird.

[ChayimFriedman2]

Changing the FxHashMap to FxIndexMap here:

rust-analyzer/crates/hir-ty/src/method_resolution/probe.rs

Line 722 in ace4702

candidates: RefCell<FxHashMap<CandidateId, CandidateWithPrivate<'db>>>,

Should fix this.

[A4-Tacks]

Also it'll be nice to add a test for the invisible method case.

This test is exists, for non pub methods in other crates