feat(diagnostics): add handler for E0040#22378
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ada4a
commented
May 16, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
requested changes
May 16, 2026
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ada4a
commented
May 16, 2026
Co-authored-by: WaterWhisperer <waterwhisperer24@qq.com>
| "#, | ||
| // Because of the error, the code isn't analyzed further (?), and so `d` is warned on as unused. | ||
| // Arguably a bug in r-a (rustc doesn't emit a warning in this case) | ||
| // FIXME: remove this once r-a no longer warns |
Contributor
There was a problem hiding this comment.
Our borrowck errors (unused stuff, mutability errors) are highly incorrect and have false positives.
ChayimFriedman2
approved these changes
May 17, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #22140
cc @WaterWhisperer