feat: add diagnostic for E0422#22393
Open
WeiTheShinobi wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
May 17, 2026
| // Find the relevant variant | ||
| let (adt_ty, Some(variant)) = self.resolve_variant(expr.into(), path, false) else { | ||
| // FIXME: Emit an error. | ||
| self.push_diagnostic(InferenceDiagnostic::UnresolvedRecordExpr { expr }); |
Contributor
There was a problem hiding this comment.
I know there was a FIXME, but I think the error should go inside resolve_variant(), which will also fix it for patterns.
| @@ -0,0 +1,45 @@ | |||
| use either::Either; | |||
| use syntax::{AstNode, ast::Expr}; | |||
Contributor
There was a problem hiding this comment.
By convention we don't use specific ast nodes, instead we refer to them as ast::Node.
| "cannot find struct, variant or union type in this scope".to_owned(), | ||
| crate::adjusted_display_range(ctx, d.expr, &|expr| match expr { | ||
| Either::Left(Expr::RecordExpr(it)) => it.path().map(|p| p.syntax().text_range()), | ||
| _ => None, |
Contributor
There was a problem hiding this comment.
If you emit the error in resolve_variant(), you also need to account for ast::Pat::{RecordPat,TupleStructPat}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #22140