feat: add simplify_match assist#22394
Open
Albab-Hasan wants to merge 2 commits into
Open
Conversation
when the scrutinee of a match is a known tuple-struct enum variant call like Some(expr) arms matching that constructor are simplified by stripping the outer wrapper and arms for other constructors of the same enum are removed as unreachable dead code.
rustbot
added
the
S-waiting-on-review
Contributor
|
Note that we have a feature freeze on assists so this PR might get closed. |
Contributor
Author
|
@ChayimFriedman2 my bad, forgot abt that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the scrutinee of a
matchis a tuple struct enum variant call the outer constructor wrapper can be stripped:Some(n)→n,Pair::Both(a, b)→(a, b))the assist bails on guards, OR patterns, unit variant scrutinees and any arm pattern that doesnt resolve to the same enum.
single segment variant paths like
Noneare syntactically parsed asIdentPatnotPathPat.resolve_bind_pat_to_constis used to differentiate them from variable bindings.closes #10443