Gramar, and spelin kleanup#10487
Conversation
|
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
One small question, while skimming over the changes :)
| desugaring. Checking this is a common first step in a lint. | ||
|
|
||
| ```rust | ||
| ```rust,ignore |
There was a problem hiding this comment.
The ignore flag is AFAIK only used by rustdoc, I know that there are tools to also run the code in md book, though. Is there a reason why you think it's better to add them? For me, it seems like this expects a certain type of markdown to be used and makes it less compatible for little reason 🤔
The rendering seems to work on GH just fine either way:
let x = 0;There was a problem hiding this comment.
@xFrednet oops, just saw your reply, thx for patience :) The reason I added it there was because some IDEs (and most like all IDEs in the future) treat any code inside the triple backticks as valid code, and try to help with it. In this case, the code is incorrect (e.g. it has a tripple dot instead of a real code: fn main() { ... }) -- which means IDEs show it as an error.
|
☔ The latest upstream changes (presumably #9102) made this pull request unmergeable. Please resolve the merge conflicts. |
Gramar, and spelin kleanup A few minor cleanups in various markdown files, mostly focusing on spelling and ignoring non-compilable codeblocks. Also a few markdown tables, etc. P.S. I'm no grammar expert, do take with a grain of salt.
|
💔 Test failed - checks-action_test |
|
The usual changelog complaint xD @bors retry |
Gramar, and spelin kleanup A few minor cleanups in various markdown files, mostly focusing on spelling and ignoring non-compilable codeblocks. Also a few markdown tables, etc. P.S. I'm no grammar expert, do take with a grain of salt. changelog: none
|
💔 Test failed - checks-action_test |
| `".."` can be used as part of the list to indicate, that the configured values should be appended to the | ||
| default configuration of Clippy. By default any configuration will replace the default value. | ||
| default configuration of Clippy. By default, any configuration will replace the default value. | ||
|
|
There was a problem hiding this comment.
This file is auto generated, from the doc comments in clippy_lints::util::conf. You can update the strings there and then run cargo collect-metadata that should update this file and make bors happy :)
There was a problem hiding this comment.
thanks @xFrednet , fixed. Storing auto-generated content in git is evil... but alas.
A few minor cleanups in various markdown files, mostly focusing on spelling and ignoring non-compilable codeblocks.
|
@bors retry |
|
@dswij I think you need to |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
5 participants
A few minor cleanups in various markdown files, mostly focusing on spelling and ignoring non-compilable codeblocks. Also a few markdown tables, etc.
P.S. I'm no grammar expert, do take with a grain of salt.
changelog: none