Remove underscore check for manual_non_exhaustive lint#11844
Merged
bors merged 1 commit intoNov 22, 2023
Merged
Conversation
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
manual_non_exhaustive-rm-underscore-check
branch
from
8c7c08e to
7cc506d
Compare
blyxyas
reviewed
Nov 22, 2023
Member
blyxyas
left a comment
blyxyas
left a comment
There was a problem hiding this comment.
Shouldn't this check also be removed from line 121? Or am I missing something?
GuillaumeGomez
force-pushed
the
manual_non_exhaustive-rm-underscore-check
branch
from
7cc506d to
91fc4b3
Compare
Member
Author
Member
|
I looked for the motivation behind checking for I also ran lintcheck for this on the top 400 crates. It triggered in 2 more cases. Both were legit: @bors r+ Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10550.
As indicated in #10559, the underscore check should be removed.
changelog: remove underscore check for
manual_non_exhaustivelintr? @blyxyas