Fix duration_suboptimal_units for small literals

[tanndlin]

View all comments

fixes #16532

changelog: [duration_suboptimal_units]: fix false positive for small integer literals whose promoted value would be at most 10.

Combined #16565 and #16596

[rustbot]

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq

[Copilot]

Pull request overview

Updates duration_suboptimal_units to avoid linting on small integer literal values where the promoted (larger-unit) value would be <= 10, addressing the false positive described in #16532.

Changes:

• Adjusts lint logic to suppress suggestions for small integer literals while still linting expressions.
• Updates lint documentation/examples to avoid the new suppression edge cases.
• Expands UI tests (including duration_constructors coverage) to validate the new behavior and expected suggestions.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
clippy_lints/src/duration_suboptimal_units.rs	Implements the <= 10 suppression rule for integer literals and updates lint docs/examples.
tests/ui/duration_suboptimal_units.rs	Adds UI coverage for small literals vs expressions and updates expected lint sites.
tests/ui/duration_suboptimal_units.fixed	Updates fixed-output expectations to match the new lint behavior.
tests/ui/duration_suboptimal_units.stderr	Updates stderr expectations for the new/shifted diagnostics.
tests/ui/duration_suboptimal_units_days_weeks.rs	Adds non-linting literal + linting expression cases under duration_constructors.
tests/ui/duration_suboptimal_units_days_weeks.fixed	Updates fixed-output expectations for the days/weeks test.
tests/ui/duration_suboptimal_units_days_weeks.stderr	Updates stderr expectations for the days/weeks test.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

View changes since this review

[ada4a]

Thank you for picking this up:)

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[tanndlin]

@rustbot ready

[ada4a]

Could you please squash down the commits? I think it would also be nice to add @Hectonight and @veeceey as co-authors to the commit

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[tanndlin]

Could you please squash down the commits? I think it would also be nice to add @Hectonight and @veeceey as co-authors to the commit

Absolutely! It's squashed with all 3 of us on the commit now

[ada4a]

Sorry, one last thing^^ Feel free to force-push

View changes since this review

[ada4a]

Ideally this file wouldn't contain any tests that require this feature. Could you please move all of those into the duration_suboptimal_units_days_weeks.rs instead?

View changes since the review

[ada4a]

r? @ada4a

Changed the changelog entry to fit the format a bit better. For posterity, here's how it used to look:

changelog: Fix [duration_suboptimal_units] false positive for small integer literals whose promoted value would be at most 10.