extend needless_borrowed_reference to lint mutable ref patterns#17012
Open
Gri-ffin wants to merge 1 commit into
Open
extend needless_borrowed_reference to lint mutable ref patterns#17012Gri-ffin wants to merge 1 commit into
Gri-ffin wants to merge 1 commit into
Conversation
Collaborator
|
rustbot has assigned @samueltardieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16022
The lint should now also fire over
&mut ref mutpatterns when the matched reference can be moved instead of reborrowed. This is a bit conservative for now as it only handles cases where:match/if let,There may be other valid cases but this should cover the straightforward ones without risking incorrect suggestions or complexities.
changelog: [
needless_borrowed_reference] now also lints certain&mut ref mutpatterns