Implement needs_async_drop in rustc and optimize async drop glue#124662
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands on #121801 and implements
Ty::needs_async_dropwhich works almost exactly the same asTy::needs_drop, which is needed for #123948.Also made compiler's async drop code to look more like compiler's regular drop code, which enabled me to write an optimization where types which do not use
AsyncDropcan simply forward async drop glue todrop_in_place. This made size of the async block from the async_drop test to decrease by 12%.