Lint against manual `impl Default` that could have been `derive`d#134175

Closed

estebank wants to merge 26 commits into

rust-lang:masterfrom

estebank:manual-default-could-be-derive

Commits on Dec 16, 2024

Make some manual `impl Default` derived
estebank
committed
Introduce `default_could_be_derived` lint
estebank
committed
Use `derive(Default)`
estebank
committed
Detect `impl Default` where fields are literals and `Default::default()` calls
estebank
committed
Explicitly consider fields set to `None` as `Default` derivable
estebank
committed
Detect when user uses default unit variant in default impl
estebank
committed
Use `#[derive(Default)]` for `std::option::Option`
estebank
committed
Also lint enums with type parameters with unit variant default
estebank
committed
Lint against manual `Default` impl if all fields are defaulted
estebank
committed
Lint structs with default field values and manual `Default`
estebank
committed
Extend `Default` lint to tuple-structs
estebank
committed
Extend support to unit-structs and add comments
estebank
committed
Rework logic to make it work x-crate and remove special cases
estebank
committed
update test output
estebank
committed
Add test for `const` "equivalent"
estebank
committed
`#[derive(Default)] struct FixupContext`
estebank
committed
Tweak lint output
estebank
committed
Split lints
estebank
committed
Fix clippy tests
estebank
committed
Use `derive(Default)` in rustfmt
estebank
committed
Derive `Default` in `tests::hash`
estebank
committed
Make lint deny-by-default (for crater run)
estebank
committed
`allow(default_could_be_derived)` in `Default` examples
estebank
committed
Mention `#[default]` in E0655 code index
estebank
committed
Fix lint example
estebank
committed
fix rebase
estebank
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Lint against manual `impl Default` that could have been `derive`d#134175

Lint against manual `impl Default` that could have been `derive`d#134175
estebank wants to merge 26 commits into
rust-lang:masterfrom
estebank:manual-default-could-be-derive

Commits on Dec 16, 2024

Make some manual `impl Default` derived

Introduce `default_could_be_derived` lint

Use `derive(Default)`

Detect `impl Default` where fields are literals and `Default::default()` calls

Explicitly consider fields set to `None` as `Default` derivable

Detect when user uses default unit variant in default impl

Use `#[derive(Default)]` for `std::option::Option`

Also lint enums with type parameters with unit variant default

Lint against manual `Default` impl if all fields are defaulted

Lint structs with default field values and manual `Default`

Extend `Default` lint to tuple-structs

Extend support to unit-structs and add comments

Rework logic to make it work x-crate and remove special cases

update test output

Add test for `const` "equivalent"

`#[derive(Default)] struct FixupContext`

Tweak lint output

Split lints

Fix clippy tests

Use `derive(Default)` in rustfmt

Derive `Default` in `tests::hash`

Make lint deny-by-default (for crater run)

`allow(default_could_be_derived)` in `Default` examples

Mention `#[default]` in E0655 code index

Fix lint example

fix rebase