Add offload support to the dist-x86_64-linux CI job

[sgasho]

View all comments

Add offload support to the dist-x86_64-linux CI job
This enables users to compile offload code without building rustc from source

• Package the offload runtime shared libraries
• Package the AMDGPU and NVPTX device runtime libraries

I checked the tarballs work by compiling & running the sample offload code here:
https://rustc-dev-guide.rust-lang.org/offload/usage.html

Before	After

There are two changes affect outside of offload (I left github comments on the relevant sections). So,

r? @Kobzol
r? @jieyouxu
r? @ZuseZ4

• Continuous of try building offload in ci #153203

[Kobzol]

@bors delegate try

[rust-bors]

✌️ @sgasho, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

[sgasho]

@bors try jobs=dist-x86_64-linux

[rust-bors]

☀️ Try build successful (CI)
Build commit: bb4478e (bb4478e7edac7d0a86c29a3ac65f56cfa1d81a72)
Base parent: 3ead112 (3ead112e67f8feb4d6b09e12f1b5d83b87698961)

[sgasho]

@bors try jobs=dist-x86_64-linux

[rust-bors]

💔 Test for 7b815a7 failed: CI. Failed job:

• try - dist-x86_64-linux (web logs, enhanced plaintext logs)

[sgasho]

@bors try jobs=dist-x86_64-linux

[rust-bors]

☀️ Try build successful (CI)
Build commit: 9872f3c (9872f3c6d16727671e9f43962be4e12c30bdf321)
Base parent: 5503df8 (5503df87342a73d0c29126a7e08dc9c1255c46ad)

[sgasho]

@bors try jobs=dist-x86_64-linux

[rust-bors]

☀️ Try build successful (CI)
Build commit: 64ca999 (64ca999aa0681333d35e35b02d81c33fa85b0e97)
Base parent: df1ae0f (df1ae0f7dd168513de2d89beb2cb7a95d4fdc118)

[rustbot]

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

[ZuseZ4]

A few notes for the llvm 23 update, that should probably go in the dev guide as well:

The offload-clang-dir option from #150108 is a workaround I only introduced to not increase build times by too much. Usually, LLVM/Offload expects users to build both Clang and Offload, so that Offload can use features recently added to Clang. They are not really willing to guarantee that Offload-23 can be bootstrapped with Clang22. However, as long as the clang used to build and the sources being build are on the same major version they agreed it should likely work, even if minor/patch versions differ. They used to have an assertion that checked for equality in major/minor/patch version, but after reporting it, they downgraded the assertion to a warning in a PR that should be part of 23. They also were quick in addressing the other breakages I reported, so I think it's fine to keep trying this setup in CI.

The other thing is that you mentioned above that you ran our website example with this build, so I guess that includes the clang-linker-wrapper call? Your first comments only mention the distribution of libs, and I'm unsure if the clang-linker-wrapper is built if we don't build clang. (The naming of these components was always a bit unlucky and changes once in a while). I had started working on a PR that teaches rustc how to directly call the LLVM apis which the linker wrapper is also using, but I never finished that one and I think it's also ont part of your gsoc proposal. Imho either solution is fine (even if we ship an incomplete toolchain for a bit), I was just curious how you tested it.

[sgasho]

Thanks for the detailed info around LLVM 23/Clang/Offload.

For clang-linker-wrapper, on the x86 dev-desktop, I cloned r-l/r and built rustc by running ./x build then I used build/x86_64-unknown-linux-gnu/llvm/bin/clang++, which automatically invoked build/x86_64-unknown-linux-gnu/llvm/bin/clang-linker-wrapper

So yes, we are shipping an incomplete toolchain as the first step in this PR.

[sgasho]

@bors try jobs=dist-x86_64-linux

[sgasho]

I had started working on a PR that teaches rustc how to directly call the LLVM apis which the linker wrapper is also using

this PR?: #149827
Continuing this work might be something I can look into after GSoC

[rust-bors]

💔 Test for 0dc28a1 failed: CI. Failed job:

• try - dist-x86_64-linux (web logs, enhanced plaintext logs)

[sgasho]

@bors try jobs=dist-x86_64-linux

[rust-bors]

💔 Test for e3aafc7 failed: CI. Failed job:

• try - dist-x86_64-linux (web logs, enhanced plaintext logs)

[sgasho]

@bors try jobs=dist-x86_64-linux

[rust-bors]

☀️ Try build successful (CI)
Build commit: 3236637 (323663757ee45dbad650ca9e228c4107aca5288b)
Base parent: 29e68fe (29e68fe2295f8fc2feb52b8cb0b61a055842fdcf)

[sgasho]

Ah, I almost forgot about this effect of not using llvm.offload=true
I'll create and open dlopen Offload(this approach is the most appropriate?) PR first.