Allow building LLVM DLL with MSVC#159574
Draft
Zoxc wants to merge 16 commits into
Draft
Conversation
There is a minor change in sorted order due to: llvm/llvm-project@5931034
There is now only a single "module asm", not one before each line.
The assume here is not really relevant to the purpose of the test, and it's position changed in LLVM 23.
Codegen changed in: llvm/llvm-project@66c1b6f
This doesn't optimize as desired since: llvm/llvm-project@21f439f
These now have additional !guid metadata.
We probably want to change this to align with Linux, but for now keep the old behavior.
It's a dependency of LLVM now.
We can start matching the codegen introduced by LLVM at [1]. This alone isn't enough to make f128 functional on the platform because libcalls use the LLVM ABI. Current behavior originally introduced in RUST-128388. [1]: llvm/llvm-project@aa47e59
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
llvm-less-dylib-symbols
branch
from
July 19, 2026 20:09
d438ff3 to
afb8f68
Compare
Contributor
Author
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 19, 2026
Allow building LLVM DLL with MSVC
Contributor
|
💔 Test for 3415beb failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
llvm-less-dylib-symbols
branch
from
July 20, 2026 07:14
afb8f68 to
13a11fd
Compare
rustbot
added
A-CI
rustbot
added
A-run-make
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows building a LLVM DLL with MSVC using the
LLVM_BUILD_LLVM_DYLIB_VISoption which limit symbols exported by the shared library.This PR as written would also change exported symbols for other targets, which may affect LLVM plugins if the required symbols are not exported.