Share _Unwind_Exception definition between native and wasm#159785
Share _Unwind_Exception definition between native and wasm#159785bjorn3 wants to merge 4 commits into
Conversation
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The wasm case below already handles this for us.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Changes like this make me wish that git's move detection weren't so horrendous. It looks okay though. @bors r+ rollup=iffy Target-specific code with target-specific consequences, not all tests run in PR CI. |
This comment has been minimized.
This comment has been minimized.
Share _Unwind_Exception definition between native and wasm And a couple of minor cleanups. Follow up to #159010
|
Locally you can use |
|
💔 Test for a86cdff failed: CI. Failed job:
|
|
@bors retry failed to connect to dockerhub |
|
Side note: this failed because Actions is still broken, I think, and it wasn't supposed to be automatically merged anyway. Will try to add as "normal" rollup and hopefully it doesn't auto-queue: @bors r+ rollup=maybe Target-specific code with target-specific consequences, not all tests run in PR CI. |
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
…they Share _Unwind_Exception definition between native and wasm And a couple of minor cleanups. Follow up to rust-lang#159010
And a couple of minor cleanups.
Follow up to #159010