Skip to content

Share _Unwind_Exception definition between native and wasm#159785

Open
bjorn3 wants to merge 4 commits into
rust-lang:mainfrom
bjorn3:refactor_unwind2
Open

Share _Unwind_Exception definition between native and wasm#159785
bjorn3 wants to merge 4 commits into
rust-lang:mainfrom
bjorn3:refactor_unwind2

Conversation

@bjorn3

@bjorn3 bjorn3 commented Jul 23, 2026

Copy link
Copy Markdown
Member

And a couple of minor cleanups.

Follow up to #159010

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 23, 2026
@rustbot

rustbot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 6 candidates

@rust-log-analyzer

This comment has been minimized.

@bjorn3
bjorn3 force-pushed the refactor_unwind2 branch from c271052 to 6b0f51b Compare July 23, 2026 19:38
@rust-log-analyzer

This comment has been minimized.

Comment thread library/unwind/src/types.rs Outdated
@bjorn3
bjorn3 force-pushed the refactor_unwind2 branch from 6b0f51b to f5260df Compare July 24, 2026 09:34
@rustbot

rustbot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@clarfonthey

Copy link
Copy Markdown
Contributor

Changes like this make me wish that git's move detection weren't so horrendous. It looks okay though.

@bors r+ rollup=iffy

Target-specific code with target-specific consequences, not all tests run in PR CI.

@rust-bors

rust-bors Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0ccc68e has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 25, 2026
Share _Unwind_Exception definition between native and wasm

And a couple of minor cleanups.

Follow up to #159010
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2026
@bjorn3

bjorn3 commented Jul 25, 2026

Copy link
Copy Markdown
Member Author

Locally you can use git show --color-moved. Github doesn't expose that unfortunately.

@rust-bors

rust-bors Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

💔 Test for a86cdff failed: CI. Failed job:

@bjorn3

bjorn3 commented Jul 25, 2026

Copy link
Copy Markdown
Member Author

@bors retry failed to connect to dockerhub

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2026
@clarfonthey

Copy link
Copy Markdown
Contributor

Side note: this failed because Actions is still broken, I think, and it wasn't supposed to be automatically merged anyway.

Will try to add as "normal" rollup and hopefully it doesn't auto-queue:

@bors r+ rollup=maybe Target-specific code with target-specific consequences, not all tests run in PR CI.

@rust-bors

rust-bors Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0ccc68e has been approved by clarfonthey

It is now in the queue for this repository.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 25, 2026
…they

Share _Unwind_Exception definition between native and wasm

And a couple of minor cleanups.

Follow up to rust-lang#159010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants