Fix PassMode::Cast ABI argument lowering#1659
Open
Kuhai9801 wants to merge 2 commits into
Open
Conversation
Kuhai9801
force-pushed
the
fix-cast-abi-padding
branch
2 times, most recently
from
c8ed51a to
c15ab15
Compare
bjorn3
reviewed
May 31, 2026
| assert_eq!(params[1].0, Size::from_bytes(8)); | ||
| assert_eq!(params[1].1.value_type, types::I64); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We don't run unit tests.
Member
|
It would be nice if we had a concrete test for a case that goes wrong without this change. |
Kuhai9801
force-pushed
the
fix-cast-abi-padding
branch
from
c15ab15 to
d3c9ff1
Compare
Kuhai9801
force-pushed
the
fix-cast-abi-padding
branch
from
d3c9ff1 to
5e8d47a
Compare
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (NB. this repo may be misconfigured) some time within the next two weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1477.
Updates
PassMode::Castlowering to pass rounded full ABI units for integer rest fields, matchingCastTarget's rounded ABI layout. Casted call arguments now spill Rust-layout storage into an ABI-sized scratch slot before loading ABI parameters, so ABI padding does not cause loads from the wrong representation.The patch also updates ABI parameter rounding for cast targets. A unit test covers the rounded integer rest case.
Verification:
git diff --checkcargo fmt --check