Skip to content

Use pointee_align when storing sized indirect arguments, matching cg_llvm behavior #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
40u5 wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

Use pointee_align when storing sized indirect arguments, matching cg_llvm behavior #867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fde971
Use pointee_align when storing sized indirect arguments, matching cg_…
40u5 Mar 31, 2026
d874907
Fix clippy::pattern_type_mismatch by using ref binding instead of mat…
40u5 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/intrinsic/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,8 +734,9 @@ impl<'gcc, 'tcx> ArgAbiExt<'gcc, 'tcx> for ArgAbi<'tcx, Ty<'tcx>> {
if self.is_ignore() {
return;
}
if self.is_sized_indirect() {
OperandValue::Ref(PlaceValue::new_sized(val, self.layout.align.abi)).store(bx, dst)
if let PassMode::Indirect { ref attrs, meta_attrs: None, .. } = self.mode {
let align = attrs.pointee_align.unwrap_or(self.layout.align.abi);
OperandValue::Ref(PlaceValue::new_sized(val, align)).store(bx, dst)
} else if self.is_unsized_indirect() {
bug!("unsized `ArgAbi` cannot be stored");
} else if let PassMode::Cast { ref cast, .. } = self.mode {
Expand Down
Loading