Skip to content

Add types team to rust-forge repo#2471

Merged
jackh726 merged 1 commit into
rust-lang:mainfrom
clarfonthey:types-forge
May 15, 2026
Merged

Add types team to rust-forge repo#2471
jackh726 merged 1 commit into
rust-lang:mainfrom
clarfonthey:types-forge

Conversation

@clarfonthey
Copy link
Copy Markdown
Contributor

For what it's worth, I have absolutely no authority to make this change and want to underline that I'm only doing this to promote a discussion.

Since rust-lang/rust-forge#1040 was limited to collaborators, but the FCP includes the types team, I noted that the types team is not actually included in the list of people who count as maintainers for that repo. It makes sense to include them even though it's likely all the relevant people are already on at least one of the other teams required to have access. It's just that the PR got heated enough to need to be locked down, and I want to make sure everyone who does have a stake in the discussion can do so.

Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that types doesn't already have this persmission, this is fine if any of the types co-leads approve.
cc @jackh726 @lcnr

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels May 15, 2026
@github-actions
Copy link
Copy Markdown

Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github
[INFO  rust_team::sync] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/rust-forge':
      Permission Changes:
        Giving team 'types' maintain permission

@jieyouxu jieyouxu marked this pull request as ready for review May 15, 2026 15:47
@jieyouxu
Copy link
Copy Markdown
Member

For what it's worth, I have absolutely no authority to make this change and want to underline that I'm only doing this to promote a discussion.

Proposing changes to fix such missing access / access oversight is completely fine.

@jieyouxu jieyouxu added the needs-team-lead-review This change requires a team/WG/PG lead to review. label May 15, 2026
@clarfonthey
Copy link
Copy Markdown
Contributor Author

Proposing changes to fix such missing access / access oversight is completely fine.

I figured so, and that's why I proposed it; I just wanted to point out that this needs external approval so that the folks who do know who needs to discuss this can make it happen.

@jackh726 jackh726 added this pull request to the merge queue May 15, 2026
@jieyouxu jieyouxu removed the needs-team-lead-review This change requires a team/WG/PG lead to review. label May 15, 2026
Merged via the queue into rust-lang:main with commit e37ab80 May 15, 2026
4 checks passed
@clarfonthey clarfonthey deleted the types-forge branch May 15, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants