Add types team to rust-forge repo#2471
Merged
Merged
Conversation
Dry-run check results |
Member
Proposing changes to fix such missing access / access oversight is completely fine. |
Contributor
Author
I figured so, and that's why I proposed it; I just wanted to point out that this needs external approval so that the folks who do know who needs to discuss this can make it happen. |
jackh726
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For what it's worth, I have absolutely no authority to make this change and want to underline that I'm only doing this to promote a discussion.
Since rust-lang/rust-forge#1040 was limited to collaborators, but the FCP includes the types team, I noted that the types team is not actually included in the list of people who count as maintainers for that repo. It makes sense to include them even though it's likely all the relevant people are already on at least one of the other teams required to have access. It's just that the PR got heated enough to need to be locked down, and I want to make sure everyone who does have a stake in the discussion can do so.