Skip to content

Highlight the whole line when too many individual words changed#2404

Merged
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:gh-range-diff-threshold-lines
May 14, 2026
Merged

Highlight the whole line when too many individual words changed#2404
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:gh-range-diff-threshold-lines

Conversation

@Urgau Urgau requested a review from Kobzol May 14, 2026 13:47
Copy link
Copy Markdown
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a bit more prcise if consecutive highlighted boxes were merged together, rather than highlighting the whole line based on the heuristic, but that sounds painful to implement, and the new version looks IMO better than the old one, so 👍

View changes since this review

@Urgau Urgau added this pull request to the merge queue May 14, 2026
Merged via the queue into rust-lang:master with commit 0a75123 May 14, 2026
3 checks passed
@Urgau Urgau deleted the gh-range-diff-threshold-lines branch May 14, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants