fix: stringify __LINE__ macro to avoid overflow#56
Open
Jxcob-R wants to merge 2 commits into
Open
Conversation
Update log_Event line member type, log_log function signature and relevant print statements compatible with new change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the expansion for the
__LINE__macro is typeintwhich may be uncomfortably small on 32-bit machines or other platforms whereintis smaller.The work around is a bit silly (as macros are), however, less dangerous than a potentially uncaught integer overflow in large source files.
A good middle ground might just to be making
linealong, although this again technically has the possibility of overflowing on rather large files.