Skip to content

feat(filter): show all options on keyboard navigation#4427

Merged
saadeghi merged 4 commits intosaadeghi:v5.6from
pdanpdan:feat/filter-focus-visible
Apr 19, 2026
Merged

feat(filter): show all options on keyboard navigation#4427
saadeghi merged 4 commits intosaadeghi:v5.6from
pdanpdan:feat/filter-focus-visible

Conversation

@pdanpdan
Copy link
Copy Markdown
Contributor

@pdanpdan pdanpdan commented Feb 6, 2026

  • the last example in docs for filter does not use filter :) - it needs a fix for button because now button will not show as selected

example: https://play.tailwindcss.com/D4HeWvWziX

ref #4424

- the last example in docs for filter does not use filter :) - it needs a fix for button because now button will not show as selected

example: https://play.tailwindcss.com/D4HeWvWziX

ref saadeghi#4424
- checkbox buttons should show as checked when in filter
- now the filter example with checkboxes works as expected (can be used with filter class and hides the reset button)
@pdanpdan pdanpdan force-pushed the feat/filter-focus-visible branch from 8c68a96 to 21573c0 Compare February 6, 2026 02:57
@saadeghi saadeghi self-assigned this Feb 7, 2026
@saadeghi saadeghi added the 5.6 label Feb 28, 2026
@saadeghi saadeghi changed the base branch from master to v5.6 April 19, 2026 15:16
@saadeghi saadeghi merged commit 23f787e into saadeghi:v5.6 Apr 19, 2026
@pdanpdan pdanpdan deleted the feat/filter-focus-visible branch April 19, 2026 15:45
#### For having multiple choices, use checkboxes. It doesn't need the filter class name.
#### For having multiple choices, use checkboxes.

<form>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be <form class="filter"> - it got lost in the merge with the changes from 5.6

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Fixed it in a new commit.
Thank you @pdanpdan 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants