ci(examples): add continuous integration for murdoku (#220)#232
ci(examples): add continuous integration for murdoku (#220)#232KayProject wants to merge 1 commit into
Conversation
Adds a CI workflow for the murdoku example, the only tier-1 reference example without an entry in .github/workflows/. - Add .github/workflows/murdoku.yml invoking example_reusable.yml, triggered on push/PR to main and develop when examples/murdoku/** (excluding markdown) or the workflow files change. - Remove the misplaced, malformed examples/murdoku/src/murdoku.yml (a stray CI definition committed into the Rust source tree). - Bump cougr-core 1.0.0 -> 1.1.0 and add the empty [workspace] table every other example carries so the crate resolves standalone. - Restructure README.md to satisfy EXAMPLE_STANDARD.md section 4 by adding the missing Known Limitations section. Closes salazarsebas#220
|
@KayProject Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
salazarsebas
left a comment
There was a problem hiding this comment.
Review — request changes (blocked by pre-existing syntax error)
The workflow setup is correct: uses example_reusable.yml, removes the misplaced src/murdoku.yml, adds [workspace] to Cargo.toml, and improves the README Known Limitations section.
CI blocker
cargo fmt --check fails because examples/murdoku/src/lib.rs has a duplicate function signature at line 549:
pub fn place_suspect(..., _suspect_idx: u32) -> MoveResult {
pub fn place_suspect(..., suspect_idx: u32) -> MoveResult {This is a pre-existing bug on main, not introduced by this PR. CI cannot pass until it is fixed.
A fix is being submitted separately to main (fix/murdoku-duplicate-fn-signature). Please rebase onto that commit once merged.
Minor note
The workflow excludes !examples/murdoku/**/*.md from path triggers, so README-only changes will not re-run CI. Consider removing that exclusion so documentation changes that affect build instructions still trigger validation.
Verdict
Rebase after the murdoku syntax fix lands on main, then re-run CI.
Background
murdokuis the canonical full-stack reference example (ECS, session keys, multi-step authorization), yet it was the only tier-1 example without an entry in.github/workflows/, leaving regressions undetected until manual verification.Changes
.github/workflows/murdoku.ymlinvoking the sharedexample_reusable.yml, triggered on push/PR tomainanddevelopwhenexamples/murdoku/**(excluding markdown) or the workflow files change — consistent with the other example workflows.examples/murdoku/src/murdoku.ymlthat had been committed into the Rust source tree; the new workflow at the correct path supersedes it.cougr-core1.0.0→1.1.0and add the empty[workspace]table every other example carries so the crate resolves standalone.EXAMPLE_STANDARD.md§4.Closes #220