Skip to content

B3: ship review queue and explainability#147

Merged
samrusani merged 1 commit intomainfrom
codex/bridge-b3-review-queue-explainability
Apr 13, 2026
Merged

B3: ship review queue and explainability#147
samrusani merged 1 commit intomainfrom
codex/bridge-b3-review-queue-explainability

Conversation

@samrusani
Copy link
Copy Markdown
Owner

Summary

  • add the B3 review surfaces alice_review_queue and alice_review_apply on top of the persisted B2 review items
  • support approve, edit-and-approve, reject, and supersede-existing actions with deterministic continuity correction semantics
  • expose explanation and provenance details so review items show why they were proposed and how approved actions affect later recall and resume behavior

Scope Notes

  • review actions map to shipped continuity semantics: approve -> confirm, edit-and-approve -> edit, reject -> delete, supersede-existing -> supersede
  • keeps alice_memory_review and alice_memory_correct as compatibility aliases
  • does not claim B4 packaging, docs closeout, or demo flows as shipped in B3

Verification

  • python3 scripts/check_control_doc_truth.py
  • ./.venv/bin/python -m pytest tests/unit tests/integration -q
  • ./.venv/bin/python scripts/run_hermes_memory_provider_smoke.py

Upgrade Overview

Protected Areas

  • continuity APIs
  • memory schema
  • trust rules
  • evidence pipeline

Compatibility Impact

This is an additive bridge-phase review layer on top of the shipped B2 capture pipeline. Existing provider and MCP workflows remain intact while explicit review queue and review apply surfaces are added for persisted review items.

Migration / Rollout

Deploy the Alice review and MCP changes together so review queue payloads, explanation fields, and action semantics stay aligned across API, MCP, recall, and resume behavior. No new packaging or demo workflow is included in this sprint.

Operator Action

Validate alice_review_queue ordering and filtering, then exercise approve, reject, edit-and-approve, and supersede-existing through alice_review_apply. Confirm approved actions change later recall and resumption output deterministically, and confirm rejected items do not behave like accepted continuity state.

Validation

Branch-local verification passed:

  • python3 scripts/check_control_doc_truth.py -> PASS
  • ./.venv/bin/python -m pytest tests/unit tests/integration -q -> 1189 passed in 196.98s (0:03:16)
  • ./.venv/bin/python scripts/run_hermes_memory_provider_smoke.py -> PASS

Rollback

Revert the squash merge commit to restore the pre-B3 review behavior, then re-run the review-specific tests, full suite, and Hermes smoke validation before redeploying.

@samrusani samrusani merged commit 8846c39 into main Apr 13, 2026
4 checks passed
@samrusani samrusani deleted the codex/bridge-b3-review-queue-explainability branch April 13, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant