Repository navigation
Conversation
l_read_name counts the NUL that ends the read name, so it is at least 1. decode accepted 0, and the record failed later and far from the cause: getReadName() threw StringIndexOutOfBoundsException, and the CIGAR, bases and qualities, found by offset from the name, decoded from the wrong bytes. decode now throws SAMFormatException, as it does for a record length below the fixed block size, and as htslib rejects the record in bam_read1.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A BAM record with a read-name length of 0 decoded without complaint and failed later; it is now rejected at decode.
l_read_namecounts the NUL that ends the name, so it is at least 1. With 0,getReadName()threwStringIndexOutOfBoundsException, and the CIGAR, bases and qualities, found by offset from the name, decoded from the wrong bytes.BAMRecordCodec.decodenow throwsSAMFormatException, as it does for a record length below the fixed block size, and as htslib'sbam_read1rejectsl_qname < 1.Found while reading broadinstitute/picard#2063.
Fixes #1948