Validate installed sbt on disk; split cache restore/save#111
Open
arashi01 wants to merge 1 commit into
Open
Conversation
Member
|
Do you know where the bug is coming from? Is |
eed3si9n
reviewed
Jul 19, 2026
Comment on lines
+94
to
+95
| # Never cache or PATH a partial extraction. | ||
| test -f "$SBT_TOOLPATH/sbt/bin/sbt" |
Member
There was a problem hiding this comment.
I wonder if we can minimize this PR to this line only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows CI intermittently fails at
Setup PATH:The distribution cache reported a hit, so
Download and Install(gated oncache-dir.outputs.cache-hit) was skipped - but the restored blob had nosbt/bin/sbt. Deleting the cache only unblocks temporarily; the poisoned blob comes back; needing a manual purge viaghto unblock/fix the build.Changes
cache-hit:Download and Installself-checkssbt/bin/sbtand re-downloads on a miss or a corrupt restore.sbt/bin/sbtafterunzipso a partial extraction fails at the install, not atSetup PATH.actions/cacheintorestore+save; save runs only after a verified install, so an incomplete$SBT_TOOLPATHis never cached and the auto post-job save that created the issue is gone.SBT_CACHE_KEY_VERSION1.1.25→1.1.26Disk cache, Linux signature verification, and the non-Windows paths are unchanged.